-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Garden Tweaks & Features #1118
Open
WannaBeIan
wants to merge
11
commits into
SkyblockerMod:master
Choose a base branch
from
WannaBeIan:dev-env
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Garden Tweaks & Features #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthegreat1
requested changes
Jan 2, 2025
src/main/java/de/hysky/skyblocker/config/configs/FarmingConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/garden/FarmingHud.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/garden/FarmingHud.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/garden/VisitorHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/garden/VisitorHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/garden/VisitorHelper.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
This PR need changes
and removed
reviews needed
This PR needs reviews
labels
Jan 2, 2025
After a discussion, we think the visitor helper options would be better in a group. If you can also do that it’d be great. |
LifeIsAParadox
added
reviews needed
This PR needs reviews
and removed
changes requested
This PR need changes
labels
Jan 3, 2025
LifeIsAParadox
added
changes requested
This PR need changes
and removed
reviews needed
This PR needs reviews
labels
Jan 6, 2025
LifeIsAParadox
added
reviews needed
This PR needs reviews
and removed
changes requested
This PR need changes
labels
Jan 6, 2025
Sorry for the messy commits. this should be everything requested change wise.
|
Emirlol
reviewed
Jan 6, 2025
The VacuumSolver could be improved by checking the scoreboard location line for the pest icon before rendering the waypoint, instead of rendering it regardless of pests. This can be addressed in a future PR. |
… method during some tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to view required crops in the visitor helper as stacks + remainder.
Visitor Helper now works outside of the Garden by default but includes a new setting to lock it to the Garden.
Fixed the regex for Farming XP so it works correctly and now displays your XP/h, even at max farming level.
Added decimals for more precise XP/h and Blocks/s calculations.
Visitors requesting the same crops are grouped together, displaying a sum of the required crops.
I am aware the code is pretty messy its been some time since I've sat down and type something up
Let me know if anything needs to be fixed, and I'll take care of it!