Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carnival Helpers #1124

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Carnival Helpers #1124

merged 2 commits into from
Jan 9, 2025

Conversation

AzureAaron
Copy link
Collaborator

No description provided.

@AzureAaron AzureAaron added the new feature This issue or PR is a new feature label Jan 4, 2025
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jan 4, 2025
kevinthegreat1
kevinthegreat1 reviewed Jan 4, 2025
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small things, otherwise all good.

src/main/java/de/hysky/skyblocker/config/configs/HelperConfig.java Outdated Show resolved Hide resolved
src/main/java/de/hysky/skyblocker/utils/Utils.java Show resolved Hide resolved
@kevinthegreat1 kevinthegreat1 added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Jan 5, 2025
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Jan 7, 2025
@AzureAaron AzureAaron force-pushed the carnival-second-take branch from 59fe092 to ab6bb6b Compare January 7, 2025 01:40
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jan 7, 2025
@kevinthegreat1 kevinthegreat1 merged commit c18bfb0 into master Jan 9, 2025
1 check passed
@kevinthegreat1 kevinthegreat1 deleted the carnival-second-take branch January 9, 2025 16:08
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinthegreat1 kevinthegreat1 kevinthegreat1 approved these changes

Assignees
No one assigned
Labels
new feature This issue or PR is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AzureAaron @kevinthegreat1 @LifeIsAParadox