-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ComboFilter.java #1133
Closed
Closed
Update ComboFilter.java #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basics working just needs lots of polish
now constantly monitors ping and makes the teleport try to last as long as last ping packet recived
add raycast so predicted camera can not go though walls. could use improvement this is not how it is done exactly on hypixels side
and update settings
adds counter for how many teleports ahead the player is to the server so receiving a teleport for an old use will not reset the camera
adds other suggested locations to disable but also a timer for if the go to long without the server teleporting them assuming that its disabled and not working until they are teleported again
still not the same but closer
there is still debug stuff in this commit
still debug stuff in
still debug
still debug
still debug
still debug
still debug
still in debug
by not updating the teleport duration while teleporting. this was causing the camera to jump if your ping changed mid teleport
give the user the option to let the annimation lag behind the game so it does not jump to the end
Now the combo message has a percent sign.
AzureAaron
added
small change
Small changes that are easier to review
bug
Something isn't working
labels
Jan 12, 2025
AzureAaron
requested changes
Jan 12, 2025
src/main/java/de/hysky/skyblocker/skyblock/chat/filters/ComboFilter.java
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
This PR need changes
and removed
reviews needed
This PR needs reviews
labels
Jan 12, 2025
bruh miswrite
LifeIsAParadox
added
reviews needed
This PR needs reviews
and removed
changes requested
This PR need changes
labels
Jan 12, 2025
While the build failed due to GHA's networking stack dying or whatever the build would've failed since the test for the combo filter hasn't been updated with a % so you need to do that as well. |
AzureAaron
previously approved these changes
Jan 13, 2025
LifeIsAParadox
added
merge me please
Pull requests that are ready to merge
and removed
reviews needed
This PR needs reviews
labels
Jan 13, 2025
Smooth aote
LifeIsAParadox
added
changes requested
This PR need changes
and removed
merge me please
Pull requests that are ready to merge
labels
Jan 15, 2025
omg I accidentally made a mess... |
I learned how to rebase. I hope nothing goes wrong... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the combo message has a percent sign.