Chat rule location config overhaul #1138
Open
+576
−518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably needs some sort of migration from the old config to the new config, that part is not done yet |
olim88
reviewed
Jan 19, 2025
| CheckboxWidget.builder(Text.of(item), client.textRenderer) | ||
| .checked(!filters.contains(item)) | ||
| CheckboxWidget.builder(Text.of(item.toString()), client.textRenderer) | ||
| .checked(whitelist == filters.contains(item)) | ||
| .callback((checkbox1, checked) -> { |
There was a problem hiding this comment.
this if (checked) needs to be flipped when the white list is enabled so instead you would want: (checked == !whitelist)
There was a problem hiding this comment.
This part is correct, inverting it causes the config to save unchecked locations as valid locations instead. The issue was the callback logic not changing according to whitelist/blacklist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the string of locations to a checkbox list for each location instead.
It's basically the powder filter screen copied over to locations.