Client-sided dungeon score calculation #497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/de/hysky/skyblocker/skyblock/dungeon/DungeonScore.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The score shown in the scoreboard is updated very late and is never equal to what score you would get if you went and completed the dungeon at that moment. That goes against its purpose and makes it harder to judge when the score is enough for S or S+. This PR is for calculating score client-side with the info gathered from various places, allowing the player to see when the score is enough.
I'm mostly confident in the calculation's accuracy, but I'm not very sure if I've handled mimics right so do let me know if you see any mistakes or any alternative ways to do it.
I've also added score to the HUD with customizable location & size, but it's a bit messy as I simply patched the dungeon map config with the relevant things. It could be improved further, especially if there are plans to add more HUD elements.