Add configurable waypoints for Goldor phase on f7. #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureAaron
requested changes
Aug 16, 2024
src/main/java/de/hysky/skyblocker/skyblock/dungeon/GoldorWaypointsManager.java
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/GoldorWaypointsManager.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/GoldorWaypointsManager.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/GoldorWaypointsManager.java
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/GoldorWaypointsManager.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/GoldorWaypointsManager.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/GoldorWaypointsManager.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
GatienDoesStuff
force-pushed
the
goldor-term-waypoints
branch
from
7d6cd86 to
9311e7d
Compare
LifeIsAParadox
added
reviews needed
AzureAaron
requested changes
Aug 17, 2024
src/main/java/de/hysky/skyblocker/skyblock/dungeon/GoldorWaypointsManager.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
GatienDoesStuff
force-pushed
the
goldor-term-waypoints
branch
from
9311e7d to
dcbea82
Compare
LifeIsAParadox
added
reviews needed
|
I took another look at the existing waypoint code, should this instead follow the class default for |
kevinthegreat1
requested changes
Aug 23, 2024
src/main/java/de/hysky/skyblocker/config/configs/DungeonsConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/dungeon/GoldorWaypointsManager.java
Outdated
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/config/categories/DungeonsCategory.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
AzureAaron
added
the
merge conflicts
LifeIsAParadox
added
reviews needed
|
Haven't tried the feature after rebasing, I'll give it a shot tonight & apply suggestions, after that it should be done. |
|
Tried it for a few runs, the waypoints are correctly rendered |
|
Thanks, but my first two comments are still not addressed. Please let me know if you need any help. |
|
Will do ! |
kevinthegreat1
approved these changes
Oct 15, 2024
LifeIsAParadox
added
merge me please
|
Is github drunk or are there requested changes that aren't marked as resolved ? I don't think I missed anything, yet, github is still complaining. |
It's cause Aaron hasn't approved yet, but I believe this pr is all good. Unless Aaron says something, you don't need to do anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds waypoints to the "tasks" phase of the catacombs floor 7. The waypoints are shown once Storm is defeated, and display one set of tasks at a time (switches whenever all tasks for a room are done).
Completed tasks are automatically hidden, by detecting the closest task to the player who just finished one. This might lead into some misdetections, if you were to complete a terminal while getting launched by the lava. You'd be closer to another terminal, which will be hidden instead of the one you actually completed.