Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wardrobe helper based on hotbar keybinds #943

Merged
merged 4 commits into from
Sep 8, 2024

Conversation

Emirlol
Copy link
Collaborator

@Emirlol Emirlol commented Aug 19, 2024

This is based on #924. Squash and merge, maybe.

The feature class extends RegexContainerMatcher to simplify regex checking and also gets a nice isEnabled override. It's not exactly necessary but it looks cleaner. The only downside is that it needs a singleton instance to use the methods on, because the methods in RegexContainerMatcher are not static.

There's also a config option in root of Helpers category outside of groups to toggle the feature.

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Aug 19, 2024
@Emirlol Emirlol added new feature This issue or PR is a new feature small change Small changes that are easier to review labels Aug 19, 2024
@Emirlol Emirlol force-pushed the wardrobe-keybinds branch from f54a583 to 34b89ae Compare August 19, 2024 16:29
@AzureAaron AzureAaron added this to the 1.23.0 milestone Aug 20, 2024
@AzureAaron AzureAaron added the merge conflicts This PR has merge conflicts that need solving. label Sep 3, 2024
@LifeIsAParadox LifeIsAParadox removed the merge conflicts This PR has merge conflicts that need solving. label Sep 8, 2024
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but will unfortunately conflict with #939.

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Sep 8, 2024
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works :D

@viciscat viciscat merged commit bd6ed47 into SkyblockerMod:master Sep 8, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Sep 8, 2024
@Emirlol Emirlol deleted the wardrobe-keybinds branch September 9, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature small change Small changes that are easier to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants