Added Purse API and Purse Change Event #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems a bit of a little random addition (apart from the regex fix)? |
|
Yeah, I was working on a slayer profit calculator and saw that there was no way of tracking purse changes like this. I thought that it was best to make it a more abstract thing so that it could be used in other similar calculators (ghost profit, bountiful reforge in farming etc). I maybe should have explained that more. |
AzureAaron
added
the
merge conflicts
|
Merge conflict looks fairly simple to fix to me. |
kevinthegreat1
requested changes
Sep 8, 2024
src/main/java/de/hysky/skyblocker/utils/purse/PurseChangeCause.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
reviews needed
|
Done @kevinthegreat1 |
|
This pr needed to be rebased. I have done that for you. I apologize for the very rapidly changing main branch, but that's bound to happen to an interdependent project like this, so it would be nice if you could deal with these situations. |
kevinthegreat1
force-pushed
the
purse-api
branch
from
7b4ad9d to
07c683a
Compare
LifeIsAParadox
added
reviews needed
|
This api was a bit messy. I have rewritten it. Feel free to take a look but it should be good now. |
kevinthegreat1
previously approved these changes
Sep 22, 2024
LifeIsAParadox
added
merge me please
src/main/java/de/hysky/skyblocker/utils/purse/PurseChangeCause.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
reviews needed
kevinthegreat1
previously approved these changes
Sep 22, 2024
LifeIsAParadox
added
merge me please
AzureAaron
added
the
merge conflicts
…pcoming feature I am making
Co-authored-by: Kevin <[email protected]>
….java Co-authored-by: Kevin <[email protected]>
…pcoming feature I am making
kevinthegreat1
force-pushed
the
purse-api
branch
from
d4fafb7 to
56b1f6e
Compare
LifeIsAParadox
added
reviews needed
kevinthegreat1
approved these changes
Nov 22, 2024
LifeIsAParadox
added
merge me please
|
Note Squash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a way to create callbacks for when the player's purse changes and fixed the Utils.getPurse function so that it would not break in the case below. This so that the Purse API can be used to track scavenger coins, useful in profit calculators for slayers and ghosts for instance.
The case that broke the getPurse function:
Purse: 372,647works fine, as the prior regex changed that to372647.However, when the purse is being updated with mob kill coins, the line becomes
Purse: 372,768 (+121), where the prior regex just removed all non digits, making it372768121.To fix this, I added a regex before the existing regex that matches the
(+nnn)section and removes it.