[Panda] PAN-3180: BpkPrice component update style (#2003)

* update color of previous price * fix additional text order in trailing mode * update screen shot * Record snapshots * Updated snapshots * Trigger pipeline rerun --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Skyscanner · Jul 11, 2024 · b1b67cc · b1b67cc
1 parent 3cac958
commit b1b67cc
Show file tree

Hide file tree

Showing 25 changed files with 3 additions and 2 deletions.
diff --git a/Backpack-SwiftUI/Price/Classes/BPKPrice.swift b/Backpack-SwiftUI/Price/Classes/BPKPrice.swift
@@ -91,8 +91,9 @@ public struct BPKPrice: View {
     private var additionalInfoLabel: some View {
         HStack(spacing: .sm) {
             ForEach(additionalInfo, id: \.self) { item in
+                let color = (item == previousPrice) ? BPKColor.textErrorColor: BPKColor.textSecondaryColor
                 BPKText(item, style: accessoryFontStyle)
-                    .foregroundColor(.textSecondaryColor)
+                    .foregroundColor(color)
                     .strikethrough(item == previousPrice)
             }
         }
@@ -142,7 +143,7 @@ public struct BPKPrice: View {
             items.append(leadingText)
         }
 
-        return alignment == .trailing ? items.reversed() : items
+        return items
     }
 }
 

diff --git a/...ice/__Snapshots__/PriceTests/test_extraSmall_withLeadingAlignment.dark-mode.png b/...ice/__Snapshots__/PriceTests/test_extraSmall_withLeadingAlignment.dark-mode.png
diff --git a/...ce/__Snapshots__/PriceTests/test_extraSmall_withLeadingAlignment.light-mode.png b/...ce/__Snapshots__/PriceTests/test_extraSmall_withLeadingAlignment.light-mode.png
diff --git a/...sts/Price/__Snapshots__/PriceTests/test_extraSmall_withLeadingAlignment.rtl.png b/...sts/Price/__Snapshots__/PriceTests/test_extraSmall_withLeadingAlignment.rtl.png
diff --git a/...s/Price/__Snapshots__/PriceTests/test_extraSmall_withRowAlignment.dark-mode.png b/...s/Price/__Snapshots__/PriceTests/test_extraSmall_withRowAlignment.dark-mode.png
diff --git a/.../Price/__Snapshots__/PriceTests/test_extraSmall_withRowAlignment.light-mode.png b/.../Price/__Snapshots__/PriceTests/test_extraSmall_withRowAlignment.light-mode.png
diff --git a/...I/Tests/Price/__Snapshots__/PriceTests/test_extraSmall_withRowAlignment.rtl.png b/...I/Tests/Price/__Snapshots__/PriceTests/test_extraSmall_withRowAlignment.rtl.png
diff --git a/...ce/__Snapshots__/PriceTests/test_extraSmall_withTrailingAlignment.dark-mode.png b/...ce/__Snapshots__/PriceTests/test_extraSmall_withTrailingAlignment.dark-mode.png
diff --git a/...e/__Snapshots__/PriceTests/test_extraSmall_withTrailingAlignment.light-mode.png b/...e/__Snapshots__/PriceTests/test_extraSmall_withTrailingAlignment.light-mode.png
diff --git a/...ts/Price/__Snapshots__/PriceTests/test_extraSmall_withTrailingAlignment.rtl.png b/...ts/Price/__Snapshots__/PriceTests/test_extraSmall_withTrailingAlignment.rtl.png
diff --git a/...ts/Price/__Snapshots__/PriceTests/test_large_withLeadingAlignment.dark-mode.png b/...ts/Price/__Snapshots__/PriceTests/test_large_withLeadingAlignment.dark-mode.png
diff --git a/...s/Price/__Snapshots__/PriceTests/test_large_withLeadingAlignment.light-mode.png b/...s/Price/__Snapshots__/PriceTests/test_large_withLeadingAlignment.light-mode.png
diff --git a/...UI/Tests/Price/__Snapshots__/PriceTests/test_large_withLeadingAlignment.rtl.png b/...UI/Tests/Price/__Snapshots__/PriceTests/test_large_withLeadingAlignment.rtl.png
diff --git a/...s/Price/__Snapshots__/PriceTests/test_large_withTrailingAlignment.dark-mode.png b/...s/Price/__Snapshots__/PriceTests/test_large_withTrailingAlignment.dark-mode.png
diff --git a/.../Price/__Snapshots__/PriceTests/test_large_withTrailingAlignment.light-mode.png b/.../Price/__Snapshots__/PriceTests/test_large_withTrailingAlignment.light-mode.png
diff --git a/...I/Tests/Price/__Snapshots__/PriceTests/test_large_withTrailingAlignment.rtl.png b/...I/Tests/Price/__Snapshots__/PriceTests/test_large_withTrailingAlignment.rtl.png
diff --git a/...ts/Price/__Snapshots__/PriceTests/test_small_withLeadingAlignment.dark-mode.png b/...ts/Price/__Snapshots__/PriceTests/test_small_withLeadingAlignment.dark-mode.png
diff --git a/...s/Price/__Snapshots__/PriceTests/test_small_withLeadingAlignment.light-mode.png b/...s/Price/__Snapshots__/PriceTests/test_small_withLeadingAlignment.light-mode.png
diff --git a/...UI/Tests/Price/__Snapshots__/PriceTests/test_small_withLeadingAlignment.rtl.png b/...UI/Tests/Price/__Snapshots__/PriceTests/test_small_withLeadingAlignment.rtl.png
diff --git a/.../Tests/Price/__Snapshots__/PriceTests/test_small_withRowAlignment.dark-mode.png b/.../Tests/Price/__Snapshots__/PriceTests/test_small_withRowAlignment.dark-mode.png
diff --git a/...Tests/Price/__Snapshots__/PriceTests/test_small_withRowAlignment.light-mode.png b/...Tests/Price/__Snapshots__/PriceTests/test_small_withRowAlignment.light-mode.png
diff --git a/...wiftUI/Tests/Price/__Snapshots__/PriceTests/test_small_withRowAlignment.rtl.png b/...wiftUI/Tests/Price/__Snapshots__/PriceTests/test_small_withRowAlignment.rtl.png
diff --git a/...s/Price/__Snapshots__/PriceTests/test_small_withTrailingAlignment.dark-mode.png b/...s/Price/__Snapshots__/PriceTests/test_small_withTrailingAlignment.dark-mode.png
diff --git a/.../Price/__Snapshots__/PriceTests/test_small_withTrailingAlignment.light-mode.png b/.../Price/__Snapshots__/PriceTests/test_small_withTrailingAlignment.light-mode.png
diff --git a/...I/Tests/Price/__Snapshots__/PriceTests/test_small_withTrailingAlignment.rtl.png b/...I/Tests/Price/__Snapshots__/PriceTests/test_small_withTrailingAlignment.rtl.png