[NO JIRA]: Update popover fallback to align with floating-ui (#3700)

Skyscanner · Jan 6, 2025 · 5d753df · 5d753df
1 parent 4dcb150
commit 5d753df
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 112 deletions.
diff --git a/packages/bpk-component-popover/index.d.ts b/packages/bpk-component-popover/index.d.ts
diff --git a/packages/bpk-component-popover/src/BpkPopover.d.ts b/packages/bpk-component-popover/src/BpkPopover.d.ts
diff --git a/packages/bpk-component-popover/src/BpkPopover.tsx b/packages/bpk-component-popover/src/BpkPopover.tsx
@@ -110,7 +110,7 @@ export type Props = CloseButtonProps & {
   closeButtonLabel?: string;
   actionText?: string;
   onAction?: () => void;
-  renderTarget?: () => HTMLElement | HTMLElement | null;
+  renderTarget?: () => HTMLElement | HTMLElement | undefined;
 };
 
 const BpkPopover = ({
@@ -130,7 +130,7 @@ const BpkPopover = ({
   onClose,
   padded = true,
   placement = 'bottom',
-  renderTarget = () => null,
+  renderTarget = () => undefined,
   showArrow = true,
   target,
   ...rest

diff --git a/packages/bpk-component-popover/src/constants.d.ts b/packages/bpk-component-popover/src/constants.d.ts
diff --git a/packages/bpk-component-popover/src/themeAttributes.d.ts b/packages/bpk-component-popover/src/themeAttributes.d.ts