Skip to content

Commit

Permalink
Revert "Revert "CAPY[909] Remove min width & height on BpkDividedCard (
Browse files Browse the repository at this point in the history
…#3658)…" (#3660)

This reverts commit af4433c.
  • Loading branch information
Sybsw authored Oct 31, 2024
1 parent af4433c commit 967c4fd
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 29 deletions.
28 changes: 11 additions & 17 deletions examples/bpk-component-card/examples.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,11 @@ const DefaultDividedCardExample = () => (
);

const VerticalDividedCardExample = () => (

<div style={{ width: 343 }}>
<BpkDividedCard
primaryContent={longMessage}
secondaryContent={shortContent}
orientation={ORIENTATION.vertical}
/>
</div>
<BpkDividedCard
primaryContent={longMessage}
secondaryContent={shortContent}
orientation={ORIENTATION.vertical}
/>
);
const WithHrefDividedCardExample = () => (
<BpkDividedCard
Expand All @@ -128,15 +125,12 @@ const WithHrefDividedCardExample = () => (
);

const NonElevatedDividedCardExample = () => (

<div style={{ width: 343 }}>
<BpkDividedCard
primaryContent={longMessage}
secondaryContent={shortContent}
orientation={ORIENTATION.vertical}
isElevated={false}
/>
</div>
<BpkDividedCard
primaryContent={longMessage}
secondaryContent={shortContent}
orientation={ORIENTATION.vertical}
isElevated={false}
/>
);

const CardWrapperExample = () => (
Expand Down
12 changes: 0 additions & 12 deletions packages/bpk-component-card/src/BpkDividedCard.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,9 @@
@use '../../unstable__bpk-mixins/tokens';
@use '../../unstable__bpk-mixins/utils';

$min-vertical-width: 240;
$max-vertical-width: 720;
$min-horizontal-width: $max-vertical-width + 1;
$min-horizontal-height: 292;
$fixed-secondary-width: 216;

.bpk-divided-card {
&--content {
display: flex;
height: 100%;
align-items: stretch;
}

Expand All @@ -38,14 +31,10 @@ $fixed-secondary-width: 216;

&--vertical-container {
display: flex;
min-width: tokens.$bpk-one-pixel-rem * $min-vertical-width;
max-width: tokens.$bpk-one-pixel-rem * $max-vertical-width;
}

&--horizontal-container {
display: flex;
min-width: tokens.$bpk-one-pixel-rem * $min-horizontal-width;
min-height: tokens.$bpk-one-pixel-rem * $min-horizontal-height;
}

&__primary {
Expand All @@ -60,7 +49,6 @@ $fixed-secondary-width: 216;
}

&--horizontal {
width: tokens.$bpk-one-pixel-rem * $fixed-secondary-width;
border-left: tokens.$bpk-input-border;

@include utils.bpk-rtl {
Expand Down

0 comments on commit 967c4fd

Please sign in to comment.