[NO JIRA]: Fix Spinner removing aria-hidden from element (#3673)

.eslintignore

@@ -5,5 +5,6 @@ coverage
 /packages/bpk-component-flare/src/__generated__
 /packages/bpk-component-icon/sm
 /packages/bpk-component-icon/lg
+/packages/bpk-component-spinner/src/spinners
 /packages/bpk-stylesheets/base.js
 *.d.ts

.gitignore

@@ -7,6 +7,7 @@
 /dist-storybook
 /coverage
 /packages/bpk-component-icon/*/
+/packages/bpk-component-spinner/src/spinners
 /packages/bpk-component-flare/src/__generated__
 !/packages/bpk-component-icon/src
 node_modules

gulpfile.js/bpk-component-spinner/gulpfile.babel.js

@@ -0,0 +1,40 @@
+/*
+ * Backpack - Skyscanner's Design System
+ *
+ * Copyright 2016 Skyscanner Ltd
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+const fs = require('fs');
+
+const gulp = require('gulp');
+
+const ICONS_FOLDER_PATH = './node_modules/@skyscanner/bpk-svgs/dist/js/spinners';
+
+const rm = (path, options) =>
+  new Promise((resolve, reject) =>
+    fs.rm(path, options, (err, ...d) => (err ? reject(err) : resolve(...d))),
+  );
+gulp.task('copy', () =>
+  gulp
+    .src(`${ICONS_FOLDER_PATH}/**/*`)
+    .pipe(gulp.dest('./packages/bpk-component-spinner/src/spinners')),
+);
+
+gulp.task('clean', () =>
+  Promise.all([
+    rm('./packages/bpk-component-spinner/src/spinners', { force: true, recursive: true }),
+  ]),
+);
+gulp.task('generateSpinners', gulp.series('clean', 'copy'));

gulpfile.js/bpk-component-spinner/gulpfile.js

@@ -0,0 +1,32 @@
+/*
+ * Backpack - Skyscanner's Design System
+ *
+ * Copyright 2016 Skyscanner Ltd
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/*
+In Babel 7+, Babel stops looking for config files once it finds a package.json. As this
+is a monorepo and the Babel config file is in the repo root, we need to tell Babel to go
+upwards up the tree to find it.
+
+Without this, gulp will not run as gulpfile.babel.js won't be transpiled and we'll get syntax
+errors.
+*/
+
+require('@babel/register')({
+  rootMode: 'upward',
+});
+
+require('./gulpfile.babel');

gulpfile.js/index.js

@@ -20,5 +20,6 @@ const gulp = require('gulp');
 
 require('./bpk-component-flare/gulpfile');
 require('./bpk-component-icon/gulpfile');
+require('./bpk-component-spinner/gulpfile');
 
-gulp.task('default', gulp.series('generateFlare', 'generateIcons'));
+gulp.task('default', gulp.series('generateFlare', 'generateIcons', 'generateSpinners'));

packages/bpk-component-spinner/src/BpkExtraLargeSpinner.tsx

@@ -16,11 +16,11 @@
  * limitations under the License.
  */
 
-import XlSpinner from '@skyscanner/bpk-svgs/dist/js/spinners/xl';
 
 import { cssModules } from '../../bpk-react-utils';
 
 import SPINNER_TYPES from './spinnerTypes';
+import XlSpinner from './spinners/xl';
 
 import type { SpinnerTypes } from './spinnerTypes';
 

packages/bpk-component-spinner/src/BpkLargeSpinner.tsx

@@ -16,11 +16,11 @@
  * limitations under the License.
  */
 
-import LgSpinner from '@skyscanner/bpk-svgs/dist/js/spinners/lg';
 
 import { cssModules } from '../../bpk-react-utils';
 
 import SPINNER_TYPES from './spinnerTypes';
+import LgSpinner from './spinners/lg';
 
 import type { SpinnerTypes } from './spinnerTypes';
 

packages/bpk-component-spinner/src/BpkSpinner.tsx

@@ -16,11 +16,11 @@
  * limitations under the License.
  */
 
-import SmSpinner from '@skyscanner/bpk-svgs/dist/js/spinners/sm';
 
 import { cssModules } from '../../bpk-react-utils';
 
 import SPINNER_TYPES from './spinnerTypes';
+import SmSpinner from './spinners/sm';
 
 import type { SpinnerTypes } from './spinnerTypes';
 

packages/bpk-component-spinner/src/themeAttributes-test.tsx

@@ -16,8 +16,6 @@
  * limitations under the License.
  */
 
-/* @flow strict */
-
 import themeAttributes from './themeAttributes';
 
 describe('themeAttributes', () => {

packages/bpk-component-spinner/src/themeAttributes.ts

@@ -16,6 +16,4 @@
  * limitations under the License.
  */
 
-/* @flow strict */
-
 export default ['spinnerPrimaryColor'];