-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARGG-816: Removed encodebase64 function #3056
Conversation
Visit https://backpack.github.io/storybook-prs/3056 to see this build running in a browser. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will also need to remove node-sass
in the root package.json
too just for a clean cut?
As I know backpack-node-sass will already bring its own version
@@ -0,0 +1 @@ | |||
registry=https://registry.npmjs.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this to stop confusing registries locally 😆
Visit https://backpack.github.io/storybook-prs/3056 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3056 to see this build running in a browser. |
Closing as being brought as part of #3103 |
After removing all the usages, we no longer need to keep this function and use it in Storybook. We also no longer require node-sass as a peerDependency
Remember to include the following changes:
README.md
(If you have created a new component)README.md