Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARGG-816: Removed encodebase64 function #3056

Closed
wants to merge 4 commits into from
Closed

ARGG-816: Removed encodebase64 function #3056

wants to merge 4 commits into from

Conversation

xalechez
Copy link
Contributor

After removing all the usages, we no longer need to keep this function and use it in Storybook. We also no longer require node-sass as a peerDependency

Remember to include the following changes:

  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@xalechez xalechez added the major Breaking change label Oct 30, 2023
@github-actions
Copy link

Visit https://backpack.github.io/storybook-prs/3056 to see this build running in a browser.

Copy link
Member

@olliecurtis olliecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also need to remove node-sass in the root package.json too just for a clean cut?

As I know backpack-node-sass will already bring its own version

@@ -0,0 +1 @@
registry=https://registry.npmjs.org
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this to stop confusing registries locally 😆

Copy link

github-actions bot commented Nov 1, 2023

Visit https://backpack.github.io/storybook-prs/3056 to see this build running in a browser.

Copy link

github-actions bot commented Nov 1, 2023

Visit https://backpack.github.io/storybook-prs/3056 to see this build running in a browser.

@olliecurtis
Copy link
Member

Closing as being brought as part of #3103

@olliecurtis olliecurtis deleted the ARGG-816 branch December 11, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DON'T MERGE major Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants