Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-8468][BpkCarousel] new component for mobile #3059
[BD-8468][BpkCarousel] new component for mobile #3059
Changes from 1 commit
e6fa988
dc3964b
419970d
54a4e82
fbb1966
91b350e
a197a5c
f6d27c5
dea5f21
c092d32
8068214
c59f9f2
324b380
d93a115
d45bbaf
30d922b
4c77737
78735ba
b4e9732
0f88af4
6999c0d
4fe4ea2
62b8513
a4a94c8
9f9a914
5779638
69ced8e
6d49dad
eb5e0d8
45afce5
184f0c5
82121da
8848e2f
2b94ca5
7e4c4aa
378b287
db88464
0ba2e0d
c405b88
7f0f9a6
bf3dd5a
61e0e8a
dd6e9ac
0b862d6
5b7142f
45f9f7f
671736e
4b44b48
532943e
a2b26ca
ae87708
b56442d
bb8ba86
ea7e121
204df25
6072d8e
b65216d
c71f6f5
0f7547f
50a8ad4
e777530
343785a
18d07c2
770f986
c1d2175
ae38ac3
8408c94
1d4bbc8
b26d506
33a3ba4
e96a40d
f5e9dae
6256ccc
dce26c4
68fde9c
5c11a3b
b1403ff
1ee0374
5701ca5
ce4f51b
a192784
c63bcb6
04ff5c3
c2d6b1e
8a23b05
5d5c885
f9e6ccc
9e5ea14
34f3ba5
c6d1e66
375c9a9
80ad9d8
9c66a3c
ebbc761
94304fd
19367e2
7f31ec1
18bf4b3
052944b
802538c
4494997
a3d617f
ad06a05
25951e3
f110224
5205779
fd79539
f00b443
ecedb79
cf11e5f
be974b1
b4b7fc1
26fb882
ea864e2
37891f2
fec7434
d2bf07f
a23b14c
06f6f51
31a5778
4c4618d
09315a1
255efae
c044b1d
ca7653b
760626e
684dc46
c4f7a35
f29e4ba
6bddd5e
647e156
3f409cb
b020538
09982ba
e9d3dc6
77e71a6
4d66ded
56ffe4e
f867ab1
f554a98
3eb8672
a807eec
b65d9fe
9fdcbf4
7a61065
dc499a8
f29412e
89b814d
f8306dd
dd98af9
49d0a78
a2183df
affd4f0
cbe3432
24e5083
1bdafe1
7232b0d
f9e782f
3fa649c
9a630a4
ee8af32
2cf166e
9a6dcfd
cecfda6
0a1ef19
304e809
5dcb070
e6f3372
5df2aa3
88f8a8a
5755d14
d8712ed
8482c8c
b365cf1
3008fe7
7aeeb00
d5efe37
638d28b
d486658
d0d10ba
825802b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be before the logic to map each of the images?
As it seems to always have the first selected image as the last one when it renders which is this expected behaviour?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ricci is away on AL now, but it seems to be in order for the scroll snap to create an infinite loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we check these in Safari as according to https://caniuse.com/?search=scroll-snap-stop it seems it isn't supported in Safari 14 which is our current lowest version supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I tried to remove
scroll-snap-stop
setting, the carousel doesn't break, could we leave it here to cover most of users to have a good experience?