BpkCardList #3076

FireRedNinja · 2023-11-08T17:01:53Z

This PR add the new component BpkCardList.

Screenshots

Rail

Grid

Row

Stack

Remember to include the following changes:

README.md (If you have created a new component)
Component README.md
Tests
Storybook examples created/updated
For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

…mponentWeb

github-actions · 2023-11-08T17:07:06Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2023-11-16T13:32:56Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2023-11-21T15:04:55Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

…mponentWeb

… into CardListComponentWeb

github-actions · 2023-11-21T16:56:39Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2023-11-28T14:18:51Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2023-11-28T14:25:55Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2023-11-28T16:51:18Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2023-11-28T16:59:35Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2023-12-07T14:36:11Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

…mponentWeb

github-actions · 2024-01-17T16:51:22Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2024-01-18T10:43:58Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2024-07-02T13:47:22Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2024-07-02T13:55:19Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2024-07-02T14:08:05Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

FireRedNinja · 2024-07-03T09:02:06Z

packages/bpk-component-carousel/src/BpkCarousel.tsx

@@ -18,7 +18,6 @@

 import { useRef, useState } from 'react';

-// @ts-expect-error Untyped import. See `decisions/imports-ts-suppressions.md`.


Typescript error was throwing on build

FireRedNinja · 2024-07-03T09:02:13Z

packages/bpk-component-chip-group/src/BpkMultiSelectChipGroup.tsx

@@ -21,7 +21,6 @@ import { useRef } from 'react';
 import BpkBreakpoint, { BREAKPOINTS } from '../../bpk-component-breakpoint';
 import BpkSelectableChip, { BpkDismissibleChip, BpkIconChip, BpkDropdownChip, CHIP_TYPES } from '../../bpk-component-chip';
 import FilterIconSm from '../../bpk-component-icon/sm/filter';
-// @ts-expect-error Untyped import. See `decisions/imports-ts-suppressions.md`.


Typescript error was throwing on build

github-actions · 2024-07-09T07:33:55Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2024-07-09T07:35:37Z

	Warnings
⚠️	Package source files (e.g. `packages/package-name/src/Component.js`) were updated, but snapshots weren't. Have you checked that the tests still pass?
⚠️	Package source files (e.g. `packages/package-name/src/Component.tsx`) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 5006ce4

…mponentWeb

github-actions · 2024-07-22T15:48:32Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2024-07-23T14:34:41Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2024-07-23T15:02:43Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

examples/bpk-component-card-list/examples.module.css

examples/bpk-component-card-list/examples.js

examples/bpk-component-card-list/examples.module.scss

packages/bpk-component-card-list/src/common-types.ts

packages/bpk-component-mobile-scroll-container/index.d.ts

packages/bpk-component-page-indicator/index.d.ts

github-actions · 2024-07-25T15:36:08Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2024-07-25T15:59:45Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

…mponentWeb

github-actions · 2024-08-06T14:34:35Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

github-actions · 2024-08-06T14:40:44Z

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

YJ Lee and others added 5 commits September 27, 2023 11:29

initial commit

227a654

progress

ad2fd2b

progress

2c66b82

split types

62f6b2e

Merge branch 'main' of github.com:Skyscanner/backpack into CardListCo…

b8689b0

…mponentWeb

olliecurtis added the minor Non breaking change label Nov 10, 2023

Merge branch 'main' into CardListComponentWeb

74779e1

fix grid and stack

39b3d31

YJ Lee added 3 commits November 21, 2023 16:25

Merge branch 'main' of github.com:Skyscanner/backpack into CardListCo…

737a2b7

…mponentWeb

Merge branch 'CardListComponentWeb' of github.com:Skyscanner/backpack…

d1bd5b1

… into CardListComponentWeb

BpkCardListRow v1

53c1248

bare minimum of responsibe grid

4b44d22

move bpkcardlistgrid to new folder

22cfbeb

added support for default items

4af5213

add typing for BpkCardListGrid

e1b7fe2

update CardList Row

d74517e

YJ Lee added 2 commits January 12, 2024 16:59

Merge branch 'main' of github.com:Skyscanner/backpack into CardListCo…

3601917

…mponentWeb

Merge branch 'main' of github.com:Skyscanner/backpack into CardListCo…

a26a004

…mponentWeb

fix grid and stack

6c0a596

Merge branch 'main' into CardListComponentWeb

04d97f4

typecheck fix

f1dac4d

update snapshots

5c29315

FireRedNinja commented Jul 3, 2024

View reviewed changes

Skyscanner deleted a comment from github-actions bot Jul 9, 2024

Merge branch 'main' into CardListComponentWeb

ff71e0a

YJ Lee added 2 commits July 22, 2024 16:43

padding variants for Row when there are different numbers of cards shown

1238a16

Merge branch 'main' of github.com:Skyscanner/backpack into CardListCo…

5f1ad0f

…mponentWeb

FireRedNinja and others added 2 commits July 23, 2024 15:28

mockCards rewrite

2a13959

generate new module

2ad6f57

FireRedNinja and others added 2 commits July 23, 2024 15:51

fix tests

11b1a53

Merge branch 'main' into CardListComponentWeb

6f68c4b

olliecurtis requested changes Jul 24, 2024

View reviewed changes

addressing comments

47c29aa

remove autogenerated files

5e83e16

YJ Lee added 2 commits August 6, 2024 15:29

address comments

a35d91e

Merge branch 'main' of github.com:Skyscanner/backpack into CardListCo…

5006ce4

…mponentWeb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BpkCardList #3076

BpkCardList #3076

FireRedNinja commented Nov 8, 2023 •

edited

Loading

github-actions bot commented Nov 8, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 21, 2023

github-actions bot commented Nov 21, 2023

github-actions bot commented Nov 28, 2023

github-actions bot commented Nov 28, 2023

github-actions bot commented Nov 28, 2023

github-actions bot commented Nov 28, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 18, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

FireRedNinja Jul 3, 2024

FireRedNinja Jul 3, 2024

github-actions bot commented Jul 9, 2024

github-actions bot commented Jul 9, 2024 •

edited

Loading

github-actions bot commented Jul 22, 2024

github-actions bot commented Jul 23, 2024

github-actions bot commented Jul 23, 2024

github-actions bot commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

github-actions bot commented Aug 6, 2024

github-actions bot commented Aug 6, 2024

		@@ -18,7 +18,6 @@

		import { useRef, useState } from 'react';

		// @ts-expect-error Untyped import. See `decisions/imports-ts-suppressions.md`.

BpkCardList #3076

Are you sure you want to change the base?

BpkCardList #3076

Conversation

FireRedNinja commented Nov 8, 2023 • edited Loading

Screenshots

Rail

Grid

Row

Stack

github-actions bot commented Nov 8, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 21, 2023

github-actions bot commented Nov 21, 2023

github-actions bot commented Nov 28, 2023

github-actions bot commented Nov 28, 2023

github-actions bot commented Nov 28, 2023

github-actions bot commented Nov 28, 2023

github-actions bot commented Dec 7, 2023

github-actions bot commented Jan 17, 2024

github-actions bot commented Jan 18, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

FireRedNinja Jul 3, 2024

Choose a reason for hiding this comment

FireRedNinja Jul 3, 2024

Choose a reason for hiding this comment

github-actions bot commented Jul 9, 2024

github-actions bot commented Jul 9, 2024 • edited Loading

Browser support

github-actions bot commented Jul 22, 2024

github-actions bot commented Jul 23, 2024

github-actions bot commented Jul 23, 2024

github-actions bot commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

github-actions bot commented Aug 6, 2024

github-actions bot commented Aug 6, 2024

FireRedNinja commented Nov 8, 2023 •

edited

Loading

github-actions bot commented Jul 9, 2024 •

edited

Loading