Wrap styles of BpkLink and bpk-stylesheets in layers #3102
Conversation
packages/bpk-stylesheets/index.scss
Outdated
| @include bpk-focus-indicator; | ||
| } | ||
| @layer utility { | ||
| /* stylelint-disable-next-line no-duplicate-at-import-rules, no-invalid-position-at-import-rule */ |
There was a problem hiding this comment.
Had to disable two lint rules here, mixins needs imported twice, each for the two layers.
This could be solved by combining theme and utility into one layer
There was a problem hiding this comment.
I was going to say everything in this file should come under one layer that I would see as base as this is core across everything and acts as the base the system then builds on
|
Visit https://backpack.github.io/storybook-prs/3102 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3102 to see this build running in a browser. |
| @@ -16,65 +16,67 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| @import '~normalize.css'; | |||
| @import '../bpk-mixins/index.scss'; | |||
| @layer base { | |||
There was a problem hiding this comment.
I suggest that before this line we define all the layers upfront, something like:
@layer base, components, overrides;
|
Superseeded by #3111 |
A test of using @layer in css to fix upstream a CSS specificity bug in footer
Remember to include the following changes:
README.md(If you have created a new component)README.md