Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WEAV-2135][BpkAccordion]: Update padding between title and expand icon to be 8px #3577

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[WEAV-2135][BpkAccordion]: Update padding between title and expand icon to be 8px #3577

wants to merge 5 commits into from

Conversation

olliecurtis
Copy link
Member

@olliecurtis olliecurtis commented Aug 7, 2024 •
edited
Loading

This change is to prevent any issues when the title is longer and prevents any squashing of content. It also fixes alignment when the title is long and the icon would align to the top of its container using flex

Before After
Screenshot 2024-08-07 at 12 50 53 Screenshot 2024-08-07 at 12 49 49

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@olliecurtis olliecurtis added the patch Patch production bug label Aug 7, 2024
@olliecurtis olliecurtis force-pushed the WEAV-2135-update-accordion-padding branch from b547960 to d43e490 Compare August 7, 2024 11:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Visit https://backpack.github.io/storybook-prs/3577 to see this build running in a browser.

1 similar comment
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3577 to see this build running in a browser.

@olliecurtis olliecurtis force-pushed the WEAV-2135-update-accordion-padding branch from e675c7f to 7ed5bd6 Compare September 30, 2024 14:16
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3577 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3577 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3577 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3577 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Visit https://backpack.github.io/storybook-prs/3577 to see this build running in a browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch Patch production bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@olliecurtis