Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAPY-909][BpkDividedCard] Remove min width & height on BpkDividedCard - Redo #3660

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[CAPY-909][BpkDividedCard] Remove min width & height on BpkDividedCard - Redo #3660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 11 additions & 17 deletions examples/bpk-component-card/examples.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,11 @@ const DefaultDividedCardExample = () => (
);

const VerticalDividedCardExample = () => (

<div style={{ width: 343 }}>
<BpkDividedCard
primaryContent={longMessage}
secondaryContent={shortContent}
orientation={ORIENTATION.vertical}
/>
</div>
<BpkDividedCard
primaryContent={longMessage}
secondaryContent={shortContent}
orientation={ORIENTATION.vertical}
/>
);
const WithHrefDividedCardExample = () => (
<BpkDividedCard
Expand All @@ -128,15 +125,12 @@ const WithHrefDividedCardExample = () => (
);

const NonElevatedDividedCardExample = () => (

<div style={{ width: 343 }}>
<BpkDividedCard
primaryContent={longMessage}
secondaryContent={shortContent}
orientation={ORIENTATION.vertical}
isElevated={false}
/>
</div>
<BpkDividedCard
primaryContent={longMessage}
secondaryContent={shortContent}
orientation={ORIENTATION.vertical}
isElevated={false}
/>
);

const CardWrapperExample = () => (
Expand Down
12 changes: 0 additions & 12 deletions packages/bpk-component-card/src/BpkDividedCard.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,9 @@
@use '../../unstable__bpk-mixins/tokens';
@use '../../unstable__bpk-mixins/utils';

$min-vertical-width: 240;
$max-vertical-width: 720;
$min-horizontal-width: $max-vertical-width + 1;
$min-horizontal-height: 292;
$fixed-secondary-width: 216;

.bpk-divided-card {
&--content {
display: flex;
height: 100%;
align-items: stretch;
}

Expand All @@ -38,14 +31,10 @@ $fixed-secondary-width: 216;

&--vertical-container {
display: flex;
min-width: tokens.$bpk-one-pixel-rem * $min-vertical-width;
max-width: tokens.$bpk-one-pixel-rem * $max-vertical-width;
}

&--horizontal-container {
display: flex;
min-width: tokens.$bpk-one-pixel-rem * $min-horizontal-width;
min-height: tokens.$bpk-one-pixel-rem * $min-horizontal-height;
}

&__primary {
Expand All @@ -60,7 +49,6 @@ $fixed-secondary-width: 216;
}

&--horizontal {
width: tokens.$bpk-one-pixel-rem * $fixed-secondary-width;
border-left: tokens.$bpk-input-border;

@include utils.bpk-rtl {
Expand Down
Loading