Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BDES-96] [BpkCardList] Add Grid and Stack Layouts #3697

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

FireRedNinja
Copy link
Contributor

@FireRedNinja FireRedNinja commented Dec 19, 2024

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

Screenshots

Grid with Header Button

image

Stack with Header Button

image

Grid with Button Accessory

image

Stack with Button Accessory

image

Grid with Expand Accessory

image
image

Stack with Expand Accessory

image

@FireRedNinja FireRedNinja added the patch Patch production bug label Dec 19, 2024
Copy link

Visit https://backpack.github.io/storybook-prs/3697 to see this build running in a browser.

@FireRedNinja FireRedNinja changed the title [BDES-96] [BpkCardList] Grid and Stack Layouts [BDES-96] [BpkCardList] Add Grid and Stack Layouts Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against e1c5ef7

Copy link

Visit https://backpack.github.io/storybook-prs/3697 to see this build running in a browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant