Upgrade to pydantic v2 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarbc96
commented
May 11, 2024
| resource_ids={"RolePolicy"}, | ||
| resource_types={"AWS::IAM::Policy"}, | ||
| ), | ||
| Failure( |
There was a problem hiding this comment.
Two new failures are added. Review if they are correct
There was a problem hiding this comment.
They are, they come from Skyscanner/pycfmodel#133 which is not included in the latest release yet
| @@ -17,7 +17,6 @@ def bad_template_no_configuration(): | |||
| "template_path", | |||
| [ | |||
| "rules/S3LifecycleConfiguration/good_template.yaml", | |||
| "rules/S3LifecycleConfiguration/allowed_template_malformed_lifecycle_rules.yaml", | |||
There was a problem hiding this comment.
If it's a malmormed policy, pycfmodel must not parse it. This test is wrong.
ignaciobolonio
previously approved these changes
May 11, 2024
| resource_ids={"RolePolicy"}, | ||
| resource_types={"AWS::IAM::Policy"}, | ||
| ), | ||
| Failure( |
There was a problem hiding this comment.
They are, they come from Skyscanner/pycfmodel#133 which is not included in the latest release yet
|
will continue in #289 as for some reason tests are not being run as we expected |
Closed
ignaciobolonio
added a commit
that referenced
this pull request
Jun 11, 2024
Upgrade to pydantic v2 (#286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: Skyscanner/pycfmodel#141