Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use one KmsIssuer for certificate requests from all namespaces #31

Closed
wants to merge 1 commit into from
Closed

Use one KmsIssuer for certificate requests from all namespaces #31

wants to merge 1 commit into from

Conversation

gietschess
Copy link

Instead of an additional custom resource (e.g. ClusterKmsIssuer) as mentioned in issue #16 i'd like so suggest an option to overwrite the namespace where the manager is looking for the KmsIssuer object instead of using the namespace where the certificate was requested.

New optional argument: "--global-kmsissuer-namespace".

@gietschess gietschess requested a review from a team as a code owner October 27, 2021 12:28
@maruina
Copy link
Collaborator

maruina commented Oct 28, 2021

Hey @gietschess, thanks for your PR.
Looking at https://cert-manager.io/docs/concepts/issuer/#namespaces it seems that the "official" way of doing it would be with a ClusterKSMIssuer. Can I ask you:

  • why the suggestion about writing the namespace with a flag
  • do you have an example of other issuer using this approach instead of a cluster level resource?

@gietschess gietschess closed this Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants