Support recursive condition #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 27, 2023 15:34
…ondition # Conflicts: # CHANGELOG.md
…ondition # Conflicts: # CHANGELOG.md
jsoucheiron
approved these changes
Oct 30, 2023
ignaciobolonio
approved these changes
Oct 30, 2023
ignaciobolonio
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue (bug or undeveloped feature) of not being able to resolve conditions when they were nested/recursive between them.
Found in some CF templates.
With this PR, pycfmodel is able to resolve conditions that depend on other conditions.
If a condition depends on another non-resolved condition, CloudFormation itself will fail as well.
Added the pytest-repeat as a way to proof conditions in the template will always follow the same order.
Package is reliable: