[KOA-6217] Bump to eslint-config-skyscanner v15, which comes with eslint 8 #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominicfraser
commented
Jul 20, 2023
| @@ -2,9 +2,9 @@ | |||
|
|
|||
| _If `@skyscanner/eslint-config-skyscanner` has a major version change then `@skyscanner/stylelint-config-skyscanner` should also have a major version change, as explained in [the docs](./docs/eslint-as-dependency.md)_ | |||
|
|
|||
| # 8.0.0 | |||
| # 9.0.0 | |||
There was a problem hiding this comment.
New UNRELEASED, almost the same as before
dominicfraser
commented
Jul 20, 2023
docs/release.md
Outdated
| @@ -17,5 +17,5 @@ Want to test your changes before making it stable and available to the general t | |||
|
|
|||
| To do this on your BRANCH or if already merged to main: | |||
| - Run `npm version <provide a custom version with the alpha or beta name e.g. 10.0.0-beta.1>`. This will create a new version in the `package.json` file and create a tagged commit (you don't need to commit this). | |||
| - Run `npm publish --tag alpha|beta` - use the correct tag depending on if you want to publish and alpha or a beta. | |||
| - Run `npm publish --registry=https://registry.npmjs.org/ --tag alpha|beta` - use the correct tag depending on if you want to publish and alpha or a beta. | |||
There was a problem hiding this comment.
Helps with copying and pasting these commands
dominicfraser
commented
Jul 20, 2023
| @@ -40,7 +40,7 @@ | |||
| "*.js": "npm run lint:fix" | |||
| }, | |||
| "dependencies": { | |||
| "@skyscanner/eslint-config-skyscanner": "^14.0.0", | |||
| "@skyscanner/eslint-config-skyscanner": "^15.0.0", | |||
There was a problem hiding this comment.
This is the actual change
olliecurtis
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in https://github.com/Skyscanner/eslint-config-skyscanner/releases/tag/v15.0.0.
This will be a major release due to: https://github.com/Skyscanner/stylelint-config-skyscanner/blob/main/docs/eslint-as-dependency.md