Skip to content

Commit

Permalink
CI: Simplify check_description_files removing obsolete --check-git-re…
Browse files Browse the repository at this point in the history
…pository-name

Following 553c045 ("CI: Update check_git_repository_name hard-coding
exceptions", 2024-03-12), exceptions are hard-coded and there is no need
to run the check only for new files.
  • Loading branch information
jcfr committed Apr 5, 2024
1 parent a3dbdcf commit d7e8ea5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
# Run checks
if [[ $added != "" ]]; then
pip install joblib retry
python ./scripts/check_description_files.py --check-git-repository-name $added
python ./scripts/check_description_files.py $added
fi
workflows:
Expand Down
7 changes: 1 addition & 6 deletions scripts/check_description_files.py
Original file line number Diff line number Diff line change
Expand Up @@ -242,9 +242,6 @@ def check_dependencies(directory):
def main():
parser = argparse.ArgumentParser(
description='Validate extension description files.')
parser.add_argument(
"--check-git-repository-name", action="store_true",
help="Check extension git repository name. Disabled by default.")
parser.add_argument(
"--check-urls-reachable", action="store_true",
help="Check homepage, iconurl and screenshoturls are reachable. Disabled by default.")
Expand All @@ -254,14 +251,12 @@ def main():

checks = []

if args.check_git_repository_name:
checks.append((check_git_repository_name, {}))

if not checks:
checks = [
(check_category, {}),
(check_contributors, {}),
(check_description, {}),
(check_git_repository_name, {}),
(check_homepage, {"check_url_reachable": args.check_urls_reachable}),
(check_iconurl, {"check_url_reachable": args.check_urls_reachable}),
(check_scmurl_syntax, {}),
Expand Down

0 comments on commit d7e8ea5

Please sign in to comment.