-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ConnectToSupervisely #2024
Add ConnectToSupervisely #2024
Conversation
Thank you for your contribution! It is very impressive how the extension and the Supervisely backend work together.
"pandas>=1.1.3, <=2.1.4",
Attempting uninstall: pandas
Found existing installation: pandas 2.2.1
Uninstalling pandas-2.2.1:
Successfully uninstalled pandas-2.2.1
ERROR: Could not install packages due to an OSError: [WinError 5] Access is denied: 'C:\\Users\\andra\\AppData\\Local\\slicer.org\\Slicer 5.7.0-2024-04-03\\lib\\Python\\Lib\\site-packages\\~andas.libs\\msvcp140-ef6047a69b174ada5cb2eff1d2bc9a62.dll' The installation process should be made more robust and it should not stop when some package installation failed but restart Slicer and retry the installation. It would be also nice to make Supervisely compatible with current pandas version.
|
Looks very cool 👍
I think |
Or |
Thank you very much for your detailed feedback 🤗 In case of name change, we would like to use |
@GoldenAnpu Does this mean the module can only connect to Supervisely, but cannot disconnect from Supervisely? If both are supported then SuperviselyConnector would seem to be the better term that implies it could do both. |
Also, it is beneficial to start the name with But |
The name
I've updated the names
The installation process has been updated
Unfortunately we can't update
I added a couple of lines of explanation and a link to a video on YouTube how our platform works. Working with our platform implies preliminary familiarization with it through documentation, blog posts, videos, etc. links to which you can see in the readme.
Yes, that was a drawback when there is only one item in the combobox. If you had several Teams, you could update the list of jobs by switching to another Team and back again. Now there are buttons to update the Job list and to Sync current Job. Implementing automatic updates would require constant API polling to retrieve user data, which is currently a bit at odds with the extension's concept of communicating with the platform only when the user explicitly requests it.
As for annotations and dynamic updating of classes and tags in Labeling Job - it depends on Labeling Job settings.
Tags may not be displayed if they are not allowed in the Labeling Job settings. If it seems like a bug, please describe the actions that led to this situation.
Could you please describe in more detail what exactly is not downloaded from the server, what is expected in Slicer and where. If we are talking about classes in the Supervisely project, their display in the segmentation list depends on the Labeling Job settings.
Changed them to non-editable |
Thanks for the updates. I'm testing the installation now, if it works then this should be ready to merge.
OK, that makes sense. I assumed that you would want to acquire new users from the Slicer community. If you want to do that you would need to provide some minimal instructions on how to set up a very simple labeling project on Supervisely. These steps should not take more than a few minutes, because until people are convinced that they should use your system, they will just not invest significantly more time into learning it. If they are hooked then they may spend a lot of time and money, but the first steps should be extremely simple.
Just my example: I clicked on the https://docs.supervisely.com/ link. Nice overview, I have a general idea of what it does. 1 minute spent. Clicked next link: https://supervisely.com/blog/ - way too many entries, how would I know which one is relevant for me? I haven't clicked on any of them. 10 seconds spent, not useful. Last video: https://www.youtube.com/watch?v=YwNHbvyZL7Q. Looks relevant, but it is 10 minutes long. If I need to watch then follow the steps it would take me at least 30 minutes to do it. That's too long, I don't have the time right now. Maybe in the afternoon or tomorrow I'll get back. Of course, by then I'll have so many other things to do, so I'll actually probably never get back to this. Anyway, all this is just free advice, helping you to reach Slicer users. If you want to get more feedback from me then I'll need more streamlined instructions on setting up a simple project in Supervisely. I don't read manuals or read blog posts, only when I'm already invested in some platform and very desperate to find information - and probably I'm not alone with this. |
I've installed the latest Slicer Preview Release on Windows. Added ConnectToSupervisely modules, restarted Slicer, switched to one of the modules, asked a few confirmations for package installations and restarted Slicer. All OK, I would have preferred only one confirmation but two OK clicks, all within a couple of seconds is fine. However, after restart I got this message:
It has just asked me a minute ago if it can replace some packages and I consented. Why does it asks me again? It is also really hard to figure out what the correct answer is, because the buttons are "Yes" and "No". What do I press if I actually want to try Supervisely? A message like "Supervisely requires updating Python packages X, Y, Z" (more details about exactly what package versions etc. can be added if the user clicks "Show details" button - just set that in Anyway, I clicked
After restart, So, I could not make it all work on a simple example within the time I could allocate to this, but the extension seems to be good enough to be added to the Extensions Index. |
The additional window after reloading 3D Slicer only appears when there were conflicts during installation. Despite the consent at the previous stage of installation, the user may change his mind for various reasons.
This error is related to the renaming of a module whose data remained in the settings file after running the previous version of the extension. @lassoan I am very pleased that you took the time to write such an extensive feedback, which will no doubt help to make our extension great. These are very valuable advices, thank you so much! |
New extension
3d-slicer-extension
GitHub topic so that it is listed here. To edit topics, click the settings icon in the right side of "About" section header and enter3d-slicer-extension
in "Topics" and click "Save changes". To learn more about topics, read https://help.github.com/en/articles/about-topicsSettings
and in repository settings uncheckWiki
,Projects
, andDiscussions
(if they are currently not used)About
in the top-right corner of the repository main page and uncheckReleases
andPackages
(if they are currently not used)