Add Python3 support #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was originally integrated in 5b9fc95 (Initial commit of Slicer4 module code)
This commit was crafted following these steps:
1. create and activate virtual environment
2. install the "future" package
pip install future
3. apply the "libfuturize.fixes.fix_absolute_import" fix
for f in `find ./ -name "*.py"`; do \
futurize -f libfuturize.fixes.fix_print_with_import --nobackups --write $f; \
done
This commit was crafted following these steps:
1. create and activate virtual environment
2. install the "future" package
pip install future
3. apply the "libpasteurize.fixes.fix_newstyle" fix
for f in `find ./ -name "*.py"`; do \
futurize -f libpasteurize.fixes.fix_newstyle --nobackups --write $f; \
done
4. revert addition of "from builtins import object"
for f in `find ./ -name "*.py"`; do \
sed -i '/from builtins import object/ d' $f; \
done
This commit was crafted following these steps:
1. create and activate virtual environment
2. install the "future" package
pip install future
3. apply the "libfuturize.fixes.fix_raise" and "lib2to3.fixes.fix_except" fixes
for f in `find ./ -name "*.py"`; do \
futurize -f libfuturize.fixes.fix_raise -f lib2to3.fixes.fix_except --nobackups --write $f; \
done
This commit was crafted following these steps:
1. create and activate virtual environment
2. install the "future" package
pip install future
3. apply the "libfuturize.fixes.fix_absolute_import" fix
for f in `find ./ -name "*.py"`; do \
futurize -f libfuturize.fixes.fix_absolute_import --nobackups --write $f; \
done
|
Thank you JC this is amazing. |
|
@jcfr thanks for doing this. Looks like many of the changes in ee7abcb and the change in e3238a9 have been merged through other PRs, e.g. #118. A few notes:
Do you want to rebase this on |
|
Notes after investigating further the changes:
|
|
Thanks for working on integrating. |
|
Do not hesitate to rebase the pull-request, I will not have to bandwidth to work on this. |
|
Thanks @jcfr. Will work on this as time permits (long-term effort). Thanks for your past contributions to the tool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are expected to be compatible with Python 2 and can be integrated.
Note that more work is required to fully support Python 3