-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deobfuscate blocks when gold panning #3921
Deobfuscate blocks when gold panning #3921
Conversation
Your Pull Request was automatically labelled as: "✨ Fix" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/3921/ac9f3cf3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just needs tested
src/main/java/io/github/thebusybiscuit/slimefun4/integrations/OrebfuscatorIntegration.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/thebusybiscuit/slimefun4/integrations/OrebfuscatorIntegration.java
Outdated
Show resolved
Hide resolved
Tested this on 1.20.1 with Orebfuscator 5.4.0 and it works flawlessly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
When using the gold pan with orebfuscator it doesn't update the obfuscated blocks
Proposed changes
Add an event handler for the gold pan to
OrebfuscatorIntegration.java
that deobfuscates the blocksRelated Issues (if applicable)
Resolves #3764
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values