Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deobfuscate blocks when gold panning #3921

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

iTwins
Copy link
Contributor

@iTwins iTwins commented Jul 26, 2023

Description

When using the gold pan with orebfuscator it doesn't update the obfuscated blocks

Proposed changes

Add an event handler for the gold pan to OrebfuscatorIntegration.java that deobfuscates the blocks

Related Issues (if applicable)

Resolves #3764

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@iTwins iTwins requested a review from a team as a code owner July 26, 2023 14:53
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Jul 26, 2023
@github-actions
Copy link
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: ac9f3cf3

https://preview-builds.walshy.dev/download/Slimefun/3921/ac9f3cf3

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

J3fftw1
J3fftw1 previously approved these changes Jul 26, 2023
JustAHuman-xD
JustAHuman-xD previously approved these changes Jul 26, 2023
Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just needs tested

@J3fftw1 J3fftw1 added the 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. label Jul 29, 2023
@iTwins iTwins dismissed stale reviews from JustAHuman-xD and J3fftw1 via e41a87d July 29, 2023 17:57
@variananora variananora added Build tested Used to indicate the PR preview build has been tested by one of the team and removed 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. labels Jul 31, 2023
@variananora
Copy link
Member

Tested this on 1.20.1 with Orebfuscator 5.4.0 and it works flawlessly.

Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@WalshyDev WalshyDev merged commit ede45dd into Slimefun:master Jul 31, 2023
11 checks passed
@iTwins iTwins deleted the fix/gold_pan_and_orebfuscator branch August 1, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build tested Used to indicate the PR preview build has been tested by one of the team ✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gold pan & Nether Gold Pan
5 participants