Feature/block drop creative #3934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Pull Request was automatically labelled as: "🎈 Feature" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/3934/5c62ae9f
|
J3fftw1
added
the
🎯 Needs testing
J3fftw1
previously requested changes
Aug 5, 2023
src/main/java/io/github/thebusybiscuit/slimefun4/implementation/listeners/BlockListener.java
Outdated
Show resolved
Hide resolved
…o feature/block-drop-creative # Conflicts: # src/main/java/io/github/thebusybiscuit/slimefun4/implementation/listeners/BlockListener.java
…n/listeners/BlockListener.java Co-authored-by: J3fftw <[email protected]>
Sefiraat
approved these changes
Sep 3, 2023
|
this appears to be working as intended. both config options worked as outlined. |
J3fftw1
added
Build tested
J3fftw1
approved these changes
Dec 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows owners to configure whether slimefun blocks should drop when broken by players in creative mode.
Proposed changes
Added a creative and config check when dropping sf block.
Related Issues (if applicable)
n/a
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values