change BREAK_BLOCK to PLACE_BLOCK in BlockPlaceEvent

[iTwins]

Description

The PlaceBlockEvent was logging block breaks

Proposed changes

change Interaction.BREAK_BLOCK to Interaction.PLACE_BLOCK

Related Issues (if applicable)

N/A

Checklist

• I have fully tested the proposed changes and promise that they will not break everything into chaos.
• I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
• I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
• I followed the existing code standards and didn't mess up the formatting.
• I did my best to add documentation to any public classes or methods I added.
• I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
• I added sufficient Unit Tests to cover my code.

[github-actions]

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

[github-actions]

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 2cb0d637

https://preview-builds.walshy.dev/download/Slimefun/3944/2cb0d637

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

[JustAHuman-xD]

I can't believe this hasn't been noticed for so long xd

[JustAHuman-xD]

It would also be good if we can get some testing to make sure this change is the proper functionality

[J3fftw1]

I did notice this before but thought it was intentional and didn’t give it any thoughts

[Sefiraat]

It’s likely gone unnoticed because the permissions for breaking and placing normally both go hand-in-hand and for those few servers with a specific distinction it’s less likely someone would trigger the behaviour in the incorrect manner like this.

[Sefiraat]

Pending removal of the resting label, looking good

[TheBusyBiscuit]

good catch 👍🏻

[TheBusyBiscuit]

It would also be good if we can get some testing to make sure this change is the proper functionality

I don't see the need for testing this as it is mainly just passing the data onto other plugins.
Besides, in dough everything is try/catch wrapped anyway and it will log any issues with its protection modules should there be a problem.

However, I noticed that our dough Logblock module does not implement block placement yet:
https://github.com/baked-libs/dough/blob/main/dough-protection/src/main/java/io/github/bakedlibs/dough/protection/loggers/LogBlockLogger.java#L28-L35
So that should be changed, otherwise only CoreProtect users will notice any difference after this change.

This PR however can be merged in my opinion if that's okay with you.