-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MockBukkit to 1.20.4 along with existing tests #4086
Conversation
Your Pull Request was automatically labelled as: "🧹 Chores" |
4fd478c
to
0915ac4
Compare
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4086/43d99917
|
0687be1
to
221698e
Compare
dd1f91e
to
1966dbe
Compare
947fea6
to
0f47916
Compare
8bcad0e
to
8233a54
Compare
Co-authored-by: J3fftw1 <[email protected]>
8233a54
to
31b199e
Compare
00dcef0
to
0f9fb1c
Compare
Co-authored-by: J3fftw1 <[email protected]>
0f9fb1c
to
4051562
Compare
Since they are all wordy things I will just commit whatever I suggested, if you disagree change stuff back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than what I committed above all looks good, check it again and if it's ok we're golden
Description
This PR updates mockbukkit.
It was a huge pain
Proposed changes
Make main class not final
Changed dependency order(this apparently matters a lot. Dont ask me why)
Changed grass material to grass_block. in 1.20.4 grass isnt a thing anymore. We should be using grass only in mocks so this shouldnt effect anything
Related Issues (if applicable)
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null valuesToDo