-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe Rewrite (API Only) #4093
Recipe Rewrite (API Only) #4093
Conversation
Your Pull Request was automatically labelled as: "🔧 API" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get unit tests on this?
yup thats my prio rn |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4093/0e8b2632
|
src/main/java/io/github/thebusybiscuit/slimefun4/implementation/Slimefun.java
Show resolved
Hide resolved
unit tests should be done, if i missed something lmk |
…ck/Slimefun4 into api/recipe-rewrite-3
Might be worth waiting for the item stack component changes before doing much more with this |
Description
This PR supersedes #4078
Description from #4078
Hey guys, this is my attempt at the recipe rewrite.
I have written up an ADR that goes over how the new API currently works, but in short:
Any feedback on the API or discussion around the new recipe system in general would be greatly appreciated!
Proposed changes
Related Issues (if applicable)
N/A
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values