-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the CropGrowthAccelerator take speed into account (grow multiple… #4107
base: master
Are you sure you want to change the base?
Conversation
Pro Tip!
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀 |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4107/b5b395ce
|
...uit/slimefun4/implementation/items/electric/machines/accelerators/CropGrowthAccelerator.java
Outdated
Show resolved
Hide resolved
...uit/slimefun4/implementation/items/electric/machines/accelerators/CropGrowthAccelerator.java
Outdated
Show resolved
Hide resolved
Merged two if statements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Can you rebase this? |
… blocks at once)
Description
This fixes the crop growth accelerator and makes it work as is advertised.
Before it's only accelerating the growth of one block at at time instead of based on the Speed parameter of the accelerator.
Proposed changes
Just take into account the speed of the accelerator block
Related Issues (if applicable)
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values