Move PlayerProfile saving off the main thread #4119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Pull Request was automatically labelled as: "🧹 Chores" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4119/5f6706bf
|
|
I tested a basic profile with just researches and with research + backpacks (both Slimefun items and vanilla). Each one could save without issue |
…tion for debug Moved the PlayerProfile saving off the main thread, we generally load this off-thread but now we also save off-thread. I thought we were already doing this but apparently not, especially with our current YAML stuff this should definitely be done Also done a small change to ensure that we don't remove the PlayerProfile from memory if the player is still online. I don't think we ever had a reported issue from this but it's kinda weird behaviour Finally, added some debug logs to the saving logic, this can be enabled with . Also added auto-complete to /sf debug because it's nice, this only works for Slimefun test cases rather than addons but that's fine. Mostly internal anyway
WalshyDev
force-pushed
the
chore/move-player-data-save-off-main-thread
branch
from
b3d2e4b
to
3d13adc
Compare
J3fftw1
previously approved these changes
Feb 5, 2024
Sfiguz7
reviewed
Feb 6, 2024
src/main/java/io/github/thebusybiscuit/slimefun4/api/player/PlayerProfile.java
Outdated
Show resolved
Hide resolved
Sfiguz7
approved these changes
Feb 6, 2024
|
WalshyDev
added
the
💡 Performance Optimization
J3fftw1
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the PlayerProfile saving off the main thread
Proposed changes
Move PlayerProfile off main thread, add debugs and improve tab completion for debug
Moved the PlayerProfile saving off the main thread, we generally load this off-thread but now we also save off-thread. I thought we were already doing this but apparently not, especially with our current YAML stuff this should definitely be done
Also done a small change to ensure that we don't remove the PlayerProfile from memory if the player is still online. I don't think we ever had a reported issue from this but it's kinda weird behaviour
Finally, added some debug logs to the saving logic, this can be enabled with
/sf debug slimefun_player_profile_data. Also added auto-complete to /sf debug because it's nice, this only works for Slimefun test cases rather than addons but that's fine. Mostly internal anywayPlease consider any cases where this will cause issues and bring them up!
I think this should be generally safe since we've been saving on-thread but loading off-thread anyway for ages but we should exercise caution. I think with the extra enforcement of the player definitely still being offline there's no issue here but give it a think before approving :)
Related Issues (if applicable)
Resolves #4118
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values