Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rc warnings #4128

Closed
wants to merge 4 commits into from
Closed

feat: rc warnings #4128

wants to merge 4 commits into from

Conversation

ybw0014
Copy link
Contributor

@ybw0014 ybw0014 commented Feb 14, 2024

Description

People who use RC versions still report bugs to Discord/GitHub, adding warning messages may possibily stop them from reporting. (just possible, people without eyes will still report)
Also fixed a issue introduced in #4096, where all the text after updater available have hover event.

This will only apply to future RC versions.

Test run (I changed the version manually to RC - 38):
image

Proposed changes

Add warning messages to /sf versions.

Related Issues (if applicable)

N/A

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@ybw0014 ybw0014 requested a review from a team as a code owner February 14, 2024 16:09
Copy link
Contributor

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

@ybw0014 ybw0014 closed this Feb 14, 2024
@ybw0014 ybw0014 deleted the feat/rc-warnings branch February 14, 2024 16:10
Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 5050e310

https://preview-builds.walshy.dev/download/Slimefun/4128/5050e310

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant