Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4216 #4218

Conversation

mcchampions
Copy link

@mcchampions mcchampions commented Jul 13, 2024

Description

Fix #4216

Proposed changes

Make the value of tickingLocations thread-safe

new HashSet() -> Collections.newSetFromMap(new ConcurrentHashMap<>())

Initialize a new HashSet on read time to avoid exceptions

Related Issues (if applicable)

#4216

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@mcchampions mcchampions requested a review from a team as a code owner July 13, 2024 13:58
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Jul 13, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 4ffef583

https://preview-builds.walshy.dev/download/Slimefun/4218/4ffef583

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with Block Ticker Task
1 participant