Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix climbing_pick_weak_surfaces.json not including sculk #4223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kub94ekCZ
Copy link
Contributor

Proposed changes

Fixes the tag, because minecraft:skulk identifier doesn't exist

Checklist

Well, I haven't actually test anything, but there is no way it could break anything

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

Copy link
Contributor

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

@Kub94ekCZ Kub94ekCZ changed the title Update climbing_pick_weak_surfaces.json Fix climbing_pick_weak_surfaces.json not including sculk Aug 14, 2024
Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 3012794

https://preview-builds.walshy.dev/download/Slimefun/4223/3012794d

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants