feat: Add RadiationDamageEvent to the api #4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pro Tip!
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀 |
JustAHuman-xD
requested changes
Aug 23, 2024
src/main/java/io/github/thebusybiscuit/slimefun4/api/events/RadiationDamageEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/thebusybiscuit/slimefun4/api/events/RadiationDamageEvent.java
Outdated
Show resolved
Hide resolved
| private static final HandlerList handlers = new HandlerList(); | ||
|
|
||
| private final Player player; | ||
| private int exposure; |
There was a problem hiding this comment.
This isn't final so I assume it's meant to be mutable, but I don't see a setExposure method
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4225/104c0b6d
|
…diationDamageEvent.java Co-authored-by: JustAHuman-xD <[email protected]>
…diationDamageEvent.java Co-authored-by: JustAHuman-xD <[email protected]>
src/main/java/io/github/thebusybiscuit/slimefun4/api/events/RadiationDamageEvent.java
Outdated
Show resolved
Hide resolved
JustAHuman-xD
previously approved these changes
Aug 23, 2024
|
Might be worth changing it to be per symptom but idk |
J3fftw1
previously approved these changes
Aug 25, 2024
src/main/java/io/github/thebusybiscuit/slimefun4/implementation/tasks/armor/RadiationTask.java
Outdated
Show resolved
Hide resolved
…n/tasks/armor/RadiationTask.java Co-authored-by: J3fftw <[email protected]>
HoosierTransfer
dismissed stale reviews from J3fftw1 and JustAHuman-xD
via
f93f0b3
Sfiguz7
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
RadiationDamageEventso that addons can cancel radiation damage.Proposed changes
Add an event that is called when the player takes radiation damga
Related Issues (if applicable)
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values