[DRAFT] Move away from dough's CustomItemStack #4249
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I can't make this a draft PR but treat this as such.
Adds a paper-dependent replacement for CustomItemStack.
Fixes issues with "class cast exception ... is not a CraftItemStack" due to usages of CustomItemStack.
This should be refactored into dough but i've made a PR here just to see the damage.
A suggested solution by @Intybyte is to keep the existing CustomItemStack constructors and then add some sort of
.getDelegate
orbuild()
method. In any case, all existing usages will cause compile errors.Proposed changes
Related Issues (if applicable)
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values