Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Move away from dough's CustomItemStack #4249

Closed

Conversation

md5sha256
Copy link
Contributor

@md5sha256 md5sha256 commented Oct 1, 2024

Description

I can't make this a draft PR but treat this as such.
Adds a paper-dependent replacement for CustomItemStack.
Fixes issues with "class cast exception ... is not a CraftItemStack" due to usages of CustomItemStack.

This should be refactored into dough but i've made a PR here just to see the damage.
A suggested solution by @Intybyte is to keep the existing CustomItemStack constructors and then add some sort of .getDelegate or build() method. In any case, all existing usages will cause compile errors.

Proposed changes

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@md5sha256 md5sha256 requested a review from a team as a code owner October 1, 2024 08:39
@github-actions github-actions bot added the 🎈 Feature This Pull Request adds a new feature. label Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Your Pull Request was automatically labelled as: "🎈 Feature"
Thank you for contributing to this project! ❤️

@md5sha256 md5sha256 changed the title Move away from dough's CustomItemStack [DRAFT] Move away from dough's CustomItemStack Oct 1, 2024
@md5sha256 md5sha256 closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎈 Feature This Pull Request adds a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant