-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/machine inventory drop #4271
base: master
Are you sure you want to change the base?
Conversation
Your Pull Request was automatically labelled as: "✨ Fix" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4271/9d621cf0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice quality-of-life improvement 👍🏻
...ava/io/github/thebusybiscuit/slimefun4/implementation/items/electric/machines/FluidPump.java
Outdated
Show resolved
Hide resolved
...ava/io/github/thebusybiscuit/slimefun4/implementation/handlers/MachineBlockBreakHandler.java
Outdated
Show resolved
Hide resolved
Co-authored-by: TheBusyBiscuit <[email protected]>
Proposed changes
Create a class extending SimpleBlockBreakHandler that handles inventories and MachineProcesoors (MachineBlockBreakHandler).
If the MachineProcessor is of CraftingOperation type and the process isn't completed, then the ingredients will be dropped.
Related Issues (if applicable)
Resolves #4268
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values