Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walshy/mc 1.21 bundles #4278

Draft
wants to merge 3 commits into
base: walshy/mc-1.21
Choose a base branch
from

Conversation

Intybyte
Copy link
Contributor

@Intybyte Intybyte commented Jan 9, 2025

Description

Bundles in 1.21.3+ will create some problems with backpacks that need to be addressed

Issues

  • Players can put bundles into backpack (Minor problem, maybe worth considering a config option for this)
  • Players can put backpacks into bundles (Major problem)

Proposed changes

  • Make a tag similar to shulker boxes in order to stop people from putting bundles inside backpacks
  • Block people from bundling up a lot of backpacks (Major problem)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@Intybyte Intybyte requested review from a team as code owners January 9, 2025 13:53
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

@Intybyte Intybyte changed the base branch from master to walshy/mc-1.21 January 9, 2025 13:53
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 62364ee

https://preview-builds.walshy.dev/download/Slimefun/4278/62364eeb

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@Intybyte Intybyte marked this pull request as draft January 11, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant