Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements #33

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Improvements #33

wants to merge 11 commits into from

Conversation

Links2004
Copy link
Contributor

Improvements:

  • detect cable with Proximity Pilot defective
  • show Errors on LCD
  • add Internal Temperature to ModBUS (0xA9)
  • show more info in serial menu

@Links2004
allow to build with cmake using xc8 compiler
4763c69 
no need for mplab

mkdir build && cd build && cmake .. && make
@Links2004
detect cable with Proximity Pilot defective
64a9818
@Links2004
show Errors on LCD
d96726c
@Links2004
add Internal Temperature to ModBUS (0xA9)
9e35927
@Links2004
show more info in serial menu
70bddcf
@Links2004
update README.md
9f4e785
@Links2004
improve menu infos
46e8807
@Links2004
add new Lock mode "Relay"
87ee00f 
Locked:
	W --> GND
	R --> 12V

Unlocked:
	W --> GND
	R --> GND

- B needs to be 0V when locked (1000 ms time see SOLENOID_REALY_DELAY_MAX)
- do not enable contactor if Lock is not OK!
- add Error messages to GLCD
@Links2004
Merge remote-tracking branch 'origin/master' into improvements
5caba02
@Links2004
allow to disable MENU via Modbus Extended Configuration registeres (0…
aed6ccb 
…xD0)
@Links2004
make line endings consistent for printf output of modbus
7879931
@Links2004 Links2004 mentioned this pull request Sep 20, 2020
Open
@bobosch
Copy link
Collaborator

bobosch commented Nov 25, 2020

Hi! What is the difference of option "solenoid" and "relais"? I thought it is the same ...

@Links2004
Copy link
Contributor Author

physically not much, both are a Induktor electrical.
but in the code for the SOLENOID does send pulses, which is bad for the relay.
and my code Introduces new checks and a ERROR_LOCK.
since I dont wanted to change the behavior for existing setups, my Idea where to introduce this as a new lock mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Links2004 @bobosch