-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Devices (Matter Switch and Matter Sensor) 4 Elko devices #1728
Conversation
Channel deleted. |
matter-sensor_coverage.xml
matter-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against d38feb3 |
deviceLabel: RFSAI-62B-SL/MT | ||
vendorId: 0x1432 | ||
productId: 0x1000 | ||
deviceProfileName: switch-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matter-switch devices that are multi-component should use the switch-binary
in the fingerprint, and then depend on the driver to create a child device for each additional switch. For example, this device would join with switch-binary
with the parent device covering the main endpoint (in this case, the lowest numbered endpoint that supports the OnOff cluster), and then an additional child device would be made for the additional child endpoint. This device would use parent-child and appear as two device cards.
With the current state of the matter-switch driver, I would not expect this profile to work as expected by design. These profiles are kept around though so we still have support for switch devices that were onboarded before the matter-switch
driver was transitioned to a primarily parent-child driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update this PR to point to the switch-binary
profile for this device.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctowns 👍 Updated.
Changing the device profile to be switch-binary
Adding an additional fingerprint for an additional WWST Cert Request.
Invitation URL: |
* new-devices-Elko-buttons-and-switches * Update fingerprints.yml Changing the device profile to be switch-binary * Adding additional Fingerprint Adding an additional fingerprint for an additional WWST Cert Request.
* new-devices-Elko-buttons-and-switches * Update fingerprints.yml Changing the device profile to be switch-binary * Adding additional Fingerprint Adding an additional fingerprint for an additional WWST Cert Request.
Check all that apply
Type of Change
Checklist
Description of Change
This PR is in support of 3 new WWST Certification Request(s)
Please review the profile assignments.
These devices may have to be broken up in to multiple PRs later but for now I kept them (to avoid merge conflicts) as one but am open to breaking them up if needed.
Summary of Completed Tests