Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Devices (Matter Switch and Matter Sensor) 4 Elko devices #1728

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

lelandblue
Copy link
Contributor

Check all that apply

Type of Change

  • [ X ] WWST Certification Request
  • Bug fix
  • New feature
  • Refactor

Checklist

  • [ X ] I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

This PR is in support of 3 new WWST Certification Request(s)

  1. deviceLabel: RFGB-40B(W)/MT, by Elko that has a Matter Device Type ID of (0xf)
  2. deviceLabel: RFWD-100/MT, by Elko, that has a Matter Device Type ID of (0x15)
  3. deviceLabel: RFSAI-62B-SL/MT, by Elko, that has a Matter Device Type ID of (0x100) according to the DCL

Please review the profile assignments.

These devices may have to be broken up in to multiple PRs later but for now I kept them (to avoid merge conflicts) as one but am open to breaking them up if needed.

Summary of Completed Tests

Copy link

github-actions bot commented Nov 4, 2024

Channel deleted.

Copy link

github-actions bot commented Nov 4, 2024

Test Results

   64 files  ±0    400 suites  ±0   0s ⏱️ ±0s
1 993 tests ±0  1 993 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 433 runs  ±0  3 433 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d6ff491. ± Comparison against base commit 8a36689.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 4, 2024

matter-sensor_coverage.xml

File Coverage
All files 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 45%

matter-switch_coverage.xml

File Coverage
All files 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/smoke-co-alarm/init.lua 83%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-sensor/src/embedded-cluster-utils.lua 45%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/aqara-cube/init.lua 96%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 96%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded-cluster-utils.lua 38%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against d38feb3

deviceLabel: RFSAI-62B-SL/MT
vendorId: 0x1432
productId: 0x1000
deviceProfileName: switch-2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matter-switch devices that are multi-component should use the switch-binary in the fingerprint, and then depend on the driver to create a child device for each additional switch. For example, this device would join with switch-binary with the parent device covering the main endpoint (in this case, the lowest numbered endpoint that supports the OnOff cluster), and then an additional child device would be made for the additional child endpoint. This device would use parent-child and appear as two device cards.

With the current state of the matter-switch driver, I would not expect this profile to work as expected by design. These profiles are kept around though so we still have support for switch devices that were onboarded before the matter-switch driver was transitioned to a primarily parent-child driver.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update this PR to point to the switch-binary profile for this device.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctowns 👍 Updated.

Adding an additional fingerprint for an additional WWST Cert Request.
@lelandblue lelandblue changed the title New Devices (Matter Switch and Matter Sensor) 3 Elko devices New Devices (Matter Switch and Matter Sensor) 4 Elko devices Nov 15, 2024
@lelandblue lelandblue merged commit 91fbde8 into main Nov 15, 2024
17 checks passed
@lelandblue lelandblue deleted the new-devices-Elko branch November 15, 2024 15:44
Copy link

lelandblue added a commit that referenced this pull request Nov 18, 2024
* new-devices-Elko-buttons-and-switches

* Update fingerprints.yml

Changing the device profile to be switch-binary

* Adding additional Fingerprint

Adding an additional fingerprint for an additional WWST Cert Request.
lelandblue added a commit that referenced this pull request Nov 18, 2024
* new-devices-Elko-buttons-and-switches

* Update fingerprints.yml

Changing the device profile to be switch-binary

* Adding additional Fingerprint

Adding an additional fingerprint for an additional WWST Cert Request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants