fix: Fixes a nil crash in the keyless bridge task. #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the bridge is missing both the application key + the bridge info, there's not much we can do until we decide how we want to handle the remedy for this situation from a UX perspective.
|
Channel deleted. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against d544227 |
greens
approved these changes
Aug 1, 2023
ctowns
approved these changes
Aug 1, 2023
|
@greens It'll already be marked that way, as it won't be able to open its SSE connection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the bridge is missing both the application key + the bridge info, there's not much we can do until we decide how we want to handle the remedy for this situation from a UX perspective.
This addresses the crash signature around CHAD-11420 but does not yet fix that bug itself.