Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the SDS doorlock issue #898

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

inasail
Copy link
Contributor

@inasail inasail commented Aug 7, 2023

https://smartthings.atlassian.net/browse/CHAD-11447

Remove configureReporting about unsupported attribute(0x21: percentage remaining)
Remove read(refresh / health check read) attribute about LockState/batteryVoltage attribute

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Channel deleted.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Test Results

     52 files     337 suites   0s ⏱️
1 596 tests 1 596 ✔️ 0 💤 0
2 752 runs  2 752 ✔️ 0 💤 0

Results for commit 6ec4190.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

File Coverage
All files 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/samsungsds/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/configurations.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/init.lua 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/yale/init.lua 81%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 6ec4190

@inasail inasail force-pushed the main branch 2 times, most recently from 8e3f9e5 to d0e5ecc Compare August 25, 2023 04:53
@inasail
Copy link
Contributor Author

inasail commented Aug 25, 2023

@greens Would you please review this PR?
Some additional issues was found from the test. Please refer to https://smartthings.atlassian.net/browse/CHAD-11447

@inasail
Copy link
Contributor Author

inasail commented Aug 29, 2023

@greens Would you please merge this PR?

@greens greens merged commit 8b795a2 into SmartThingsCommunity:main Aug 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants