Lazy load zwave switch sub drivers #921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Channel deleted. |
Test Results 52 files ±0 344 suites ±0 0s ⏱️ ±0s For more details on these errors, see this check. Results for commit 196ee7f. ± Comparison against base commit 38c1a61. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 196ee7f |
greens
reviewed
Aug 17, 2023
| require("zooz-zen-30-dimmer-relay"), | ||
| require("multichannel-device"), | ||
| require("aeotec-smart-switch") | ||
| Driver.lazy_load_subdriver(require("eaton-accessory-dimmer")), |
There was a problem hiding this comment.
won't this be in the ZwaveDriver object? I don't think you have to additionally include Driver here, do you?
This utilizes a new method of loading subdrivers that allows the sub drivers to be dynamically loaded when needed rather than having every subdriver loaded at initialization.
ctowns
force-pushed
the
lazy-load-zwave-switch
branch
from
05cfbf5
to
196ee7f
Compare
greens
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utilizes a new method of loading subdrivers that allows the sub drivers to be dynamically loaded when needed rather than having every subdriver loaded at initialization.