Add TUO for Contact Sensor Driver #933
Conversation
|
|
|
Channel deleted. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 05533bd |
|
Hello @sam-gabbay. Thank you for your pull request. Please sign the CLA. Have a good day. |
|
@lelandblue it has been signed, I am not sure why it is showing as not signed yet. |
|
Thanks @sam-gabbay I will take a look. Also, this PR will need changes before we can continue with WWST for this device. Currently in the PR I am not seeing the full addition of a device-specific fingerprint. Please take a look here at our documentation for further guidance https://developer.smartthings.com/docs/devices/hub-connected/driver-components-and-structure#matter |
|
@lelandblue updated. Please let me know if this is what you needed. |
| - id: "TUO/ContactDoorAndWindow" | ||
| deviceLabel: TUO Contact Sensor | ||
| vendorId: 0x141E | ||
| productId: 0x02 |
There was a problem hiding this comment.
Could you add the leading zeros to the productId so it has 4 digits like the other examples? e.g.
productId: 0x0002
|
Done @ctowns |
|
@ctowns @lelandblue can you advise what is needed at this point? |
|
@sam-gabbay Can you please sync your forked repo with the latest from the main repo so that the units tests will pass? |
|
@ctowns Done! |
Thanks @sam-gabbay! All tests are passing now, this looks good to me. |
|
Hello @TUOAccessoriesCI Can you please sign the CLA please? We will need that signed before we can merge the code. Thank you. |
|
@lelandblue Done |
No description provided.