Guard against a nil table lookup at cleanup. #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dljsjr
requested review from
greens,
FreeMasen,
cjswedes,
ctowns and
NoahCornell
|
Channel deleted. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 7859188 |
cjswedes
approved these changes
Aug 31, 2023
| @@ -249,7 +249,7 @@ function SonosWebSocketRouter.close_socket_for_player(target) | |||
| if ws ~= nil then | |||
| local ws_id = ws.id | |||
| table.insert(pending_close, target) | |||
| for _, uuid in ipairs(listener_ids_for_socket[ws_id]) do | |||
| for _, uuid in ipairs((listener_ids_for_socket[ws_id] or {})) do | |||
There was a problem hiding this comment.
nit: unnecessary parentheses
greens
approved these changes
Aug 31, 2023
ctowns
approved these changes
Aug 31, 2023
dljsjr
force-pushed
the
fix/nil-crash-in-cleanup-routine
branch
from
ea601a6
to
7859188
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.