Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wayland: add cursor_shape_v1 support #1154

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

kchibisov
Copy link
Member

@kchibisov kchibisov commented Oct 2, 2023

--

The protocol is dead simple and requiring a full rendering impl sounds overkill for it, given
that compositors can opt-in into this protocol, when they can handle the cursor themes.

Tested that it only reaches the compositor with YaLTeR/niri#32 , but the actual rendering is not done, and only default cursor is properly rendered.

Testing client https://github.com/Smithay/client-toolkit/blob/master/examples/themed_window.rs (press Shift + n to cycle icons).

Cargo.toml Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Attention: 165 lines in your changes are missing coverage. Please review.

Comparison is base (74ef59a) 22.71% compared to head (16d0ba3) 22.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1154      +/-   ##
==========================================
- Coverage   22.71%   22.58%   -0.14%     
==========================================
  Files         144      146       +2     
  Lines       23366    23533     +167     
==========================================
+ Hits         5308     5314       +6     
- Misses      18058    18219     +161     
Flag Coverage Δ
wlcs-buffer 19.48% <2.92%> (-0.13%) ⬇️
wlcs-core 19.13% <2.92%> (-0.13%) ⬇️
wlcs-output 7.98% <2.92%> (-0.05%) ⬇️
wlcs-pointer-input 21.37% <3.50%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
anvil/src/drawing.rs 41.81% <100.00%> (ø)
anvil/src/state.rs 36.81% <100.00%> (ø)
src/input/pointer/cursor_image.rs 100.00% <100.00%> (ø)
src/input/pointer/mod.rs 34.36% <100.00%> (ø)
src/wayland/tablet_manager/mod.rs 8.19% <ø> (ø)
src/wayland/tablet_manager/tablet_tool.rs 0.00% <ø> (ø)
wlcs_anvil/src/main_loop.rs 69.79% <0.00%> (ø)
src/wayland/cursor_shape.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Drakulix Drakulix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Cargo.toml Show resolved Hide resolved
@Drakulix Drakulix merged commit b2bfac9 into Smithay:master Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants