No need for thread attributes (unused)

Smithsonian · Sep 4, 2024 · cc47d9e · cc47d9e
1 parent 4d2702b
commit cc47d9e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 10 deletions.
diff --git a/include/redisx-priv.h b/include/redisx-priv.h
@@ -11,8 +11,6 @@
 #ifndef REDISX_PRIV_H_
 #define REDISX_PRIV_H_
 
-
-
 /// \cond PRIVATE
 
 #include <pthread.h>

diff --git a/include/redisx.h b/include/redisx.h
@@ -25,7 +25,7 @@
 #endif
 
 #ifndef REDIS_CMDBUF_SIZE
-/// (bytes) Size of many internal arrays, and the max. send size. At least ~16 bytes...
+/// (bytes) Size of many internal arrays, and the max. send chunk size. At least ~16 bytes...
 #  define REDIS_CMDBUF_SIZE               8192
 #endif
 

diff --git a/src/redisx.c b/src/redisx.c
@@ -41,10 +41,6 @@ typedef struct ServerLink {
 static ServerLink *serverList;
 static pthread_mutex_t serverLock = PTHREAD_MUTEX_INITIALIZER;
 
-
-// The response listener threads...
-static pthread_attr_t threadConfig;
-
 /// \endcond
 
 /// \cond PRIVATE
@@ -226,7 +222,6 @@ Redis *redisxInit(const char *server) {
 
   if(!isInitialized) {
     // Initialize the thread attributes once only to avoid segfaulting...
-    pthread_attr_init(&threadConfig);
     atexit(rShutdownAsync);
     isInitialized = TRUE;
   }
@@ -801,7 +796,7 @@ int rStartSubscriptionListenerAsync(Redis *redis) {
 
   p->isSubscriptionListenerEnabled = TRUE;
 
-  if (pthread_create(&p->subscriptionListenerTID, &threadConfig, RedisSubscriptionListener, redis) == -1) {
+  if (pthread_create(&p->subscriptionListenerTID, NULL, RedisSubscriptionListener, redis) == -1) {
     perror("ERROR! Redis-X : pthread_create SubscriptionListener");
     p->isSubscriptionListenerEnabled = FALSE;
     return -1;
@@ -834,7 +829,7 @@ int rStartPipelineListenerAsync(Redis *redis) {
 
   p->isPipelineListenerEnabled = TRUE;
 
-  if (pthread_create(&p->pipelineListenerTID, &threadConfig, RedisPipelineListener, redis) == -1) {
+  if (pthread_create(&p->pipelineListenerTID, NULL, RedisPipelineListener, redis) == -1) {
     perror("ERROR! Redis-X : pthread_create PipelineListener");
     p->isPipelineListenerEnabled = FALSE;
     return -1;