Some missing error propagation

Smithsonian · Dec 11, 2024 · dd70771 · dd70771
1 parent 9b89be8
commit dd70771
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/xchange.c b/src/xchange.c
@@ -225,7 +225,6 @@ int xElementSizeOf(XType type) {
     case X_FIELD: return sizeof(XField);
   }
 
-  x_error(0, EINVAL, "xElementSizeOf", "invalid type: %d ('%c')", type, type);
   return 0;
 }
 

diff --git a/src/xstruct.c b/src/xstruct.c
@@ -1025,7 +1025,10 @@ char *xCopyIDToken(const char *id) {
   char *token;
   int l;
 
-  if(!id) return NULL;
+  if(!id) {
+    x_error(X_NULL, EINVAL, "xCopyIDToken", "input ID is NULL");
+    return NULL;
+  }
 
   // Ignore leading separator.
   if(!strncmp(id, X_SEP, X_SEP_LENGTH)) id += X_SEP_LENGTH;
-Original file line number
+Diff line change
@@ Expand Up / @@ -225,7 +225,6 @@ int xElementSizeOf(XType type) { @@
         case X_FIELD: return sizeof(XField);
       }
-      x_error(0, EINVAL, "xElementSizeOf", "invalid type: %d ('%c')", type, type);
       return 0;
     }
@@ Expand Down @@